Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
index ca6efb90301fa66a644ecd172a0127a64707f521..2d8457cf5b3804e9360ccbbed5720b95b0f5caa2 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
@@ -216,8 +216,7 @@ public class OfflinePageSavePageLaterEvaluationTest
*/
private void initializeBridgeForProfile(final boolean useTestingScheduler)
throws InterruptedException {
- final Semaphore semaphore = new Semaphore(0);
- ThreadUtils.runOnUiThread(new Runnable() {
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
Profile profile = Profile.getLastUsedProfile();
@@ -226,21 +225,8 @@ public class OfflinePageSavePageLaterEvaluationTest
fail("OfflinePageEvaluationBridge initialization failed!");
return;
}
- if (mBridge.isOfflinePageModelLoaded()) {
- semaphore.release();
- return;
- }
- mBridge.addObserver(new OfflinePageEvaluationObserver() {
- @Override
- public void offlinePageModelLoaded() {
- semaphore.release();
- mBridge.removeObserver(this);
- }
- });
}
});
- checkTrue(semaphore.tryAcquire(PAGE_MODEL_LOAD_TIMEOUT_MS, TimeUnit.MILLISECONDS),
- "Timed out when loading OfflinePageModel!");
}
/**

Powered by Google App Engine
This is Rietveld 408576698