Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java
index 88ddea19f7c5a3321423f33050511621b808f6c0..b6149bd2132ac2ac2ad793da98509f3842479d12 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java
@@ -10,7 +10,6 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.chrome.browser.ChromeActivity;
-import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.OfflinePageModelObserver;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge.SavePageCallback;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.tab.Tab;
@@ -40,7 +39,6 @@ public class OfflinePageRequestTest extends ChromeActivityTestCaseBase<ChromeAct
@Override
protected void setUp() throws Exception {
super.setUp();
- final Semaphore semaphore = new Semaphore(0);
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
@@ -51,20 +49,8 @@ public class OfflinePageRequestTest extends ChromeActivityTestCaseBase<ChromeAct
Profile profile = Profile.getLastUsedProfile();
mOfflinePageBridge = OfflinePageBridge.getForProfile(profile);
- if (mOfflinePageBridge.isOfflinePageModelLoaded()) {
- semaphore.release();
- } else {
- mOfflinePageBridge.addObserver(new OfflinePageModelObserver() {
- @Override
- public void offlinePageModelLoaded() {
- semaphore.release();
- mOfflinePageBridge.removeObserver(this);
- }
- });
- }
}
});
- assertTrue(semaphore.tryAcquire(TIMEOUT_MS, TimeUnit.MILLISECONDS));
}
@Override

Powered by Google App Engine
This is Rietveld 408576698