Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index 4624e4f133fcf0b2e51be792ee178c2814bf652d..9a2add726e10cd2ce8dc16b602c37b82228eda17 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -147,11 +147,6 @@ public class SuggestionsSection extends InnerNode {
final OfflinePageBridge.OfflinePageModelObserver observer =
new OfflinePageBridge.OfflinePageModelObserver() {
@Override
- public void offlinePageModelLoaded() {
- updateAllSnippetOfflineAvailability();
dewittj 2016/12/12 19:41:53 NTP folks: Do we need to call |updateAllSnippetOff
- }
-
- @Override
public void offlinePageAdded(OfflinePageItem addedPage) {
updateAllSnippetOfflineAvailability();
}
@@ -246,7 +241,6 @@ public class SuggestionsSection extends InnerNode {
private void updateSnippetOfflineAvailability(final SnippetArticle article) {
// This method is not applicable to articles for which the exact offline id must specified.
assert !article.requiresExactOfflinePage();
- if (!mOfflinePageBridge.isOfflinePageModelLoaded()) return;
// TabId is relevant only for recent tab offline pages, which we do not handle here, so we
// do not care about tab id.
mOfflinePageBridge.selectPageForOnlineUrl(

Powered by Google App Engine
This is Rietveld 408576698