Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java
index 5be2a6e165ea8b6c057b03c09a77915a3d49e004..1a5f39435ccf31a32fedd43a2f2d7042f1d81735 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/evaluation/OfflinePageEvaluationBridge.java
@@ -38,11 +38,6 @@ public class OfflinePageEvaluationBridge {
*/
public abstract static class OfflinePageEvaluationObserver {
/**
- * Event fired when the offline page model is loaded.
- */
- public void offlinePageModelLoaded() {}
-
- /**
* Event fired when a new request is added.
* @param request The newly added save page request.
*/
@@ -77,7 +72,6 @@ public class OfflinePageEvaluationBridge {
private static final String TAG = "OPEvalBridge";
private long mNativeOfflinePageEvaluationBridge;
- private boolean mIsOfflinePageModelLoaded;
private ObserverList<OfflinePageEvaluationObserver> mObservers =
new ObserverList<OfflinePageEvaluationObserver>();
@@ -169,13 +163,6 @@ public class OfflinePageEvaluationBridge {
mLogOutput = new FileWriter(outputFile);
}
- /**
- * @return True if the offline page model has fully loaded.
- */
- public boolean isOfflinePageModelLoaded() {
- return mIsOfflinePageModelLoaded;
- }
-
@CalledByNative
public void log(String sourceTag, String message) {
try {
@@ -219,20 +206,11 @@ public class OfflinePageEvaluationBridge {
}
@CalledByNative
- void offlinePageModelLoaded() {
- mIsOfflinePageModelLoaded = true;
- for (OfflinePageEvaluationObserver observer : mObservers) {
- observer.offlinePageModelLoaded();
- }
- }
-
- @CalledByNative
private void offlinePageEvaluationBridgeDestroyed() {
ThreadUtils.assertOnUiThread();
assert mNativeOfflinePageEvaluationBridge != 0;
mNativeOfflinePageEvaluationBridge = 0;
- mIsOfflinePageModelLoaded = false;
mObservers.clear();
}

Powered by Google App Engine
This is Rietveld 408576698