Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 2564163002: [Offline Pages] Remove load state from public OfflinePageModel API. (Closed)
Patch Set: Fix broken tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index 04d12de78185e6702704f5cf23fc9c652e912854..ba8eb8fd13dc9096cb3ed49c8f9d74d5f94e3813 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -40,7 +40,6 @@ public class OfflinePageBridge {
}
private long mNativeOfflinePageBridge;
- private boolean mIsNativeOfflinePageModelLoaded;
private final ObserverList<OfflinePageModelObserver> mObservers =
new ObserverList<OfflinePageModelObserver>();
@@ -70,11 +69,6 @@ public class OfflinePageBridge {
*/
public abstract static class OfflinePageModelObserver {
/**
- * Called when the native side of offline pages is loaded and now in usable state.
- */
- public void offlinePageModelLoaded() {}
-
- /**
* Called when the native side of offline pages is changed due to adding, removing or
* update an offline page.
*/
@@ -292,7 +286,6 @@ public class OfflinePageBridge {
*/
public void savePage(final WebContents webContents, final ClientId clientId,
final SavePageCallback callback) {
- assert mIsNativeOfflinePageModelLoaded;
assert webContents != null;
nativeSavePage(mNativeOfflinePageBridge, callback, webContents, clientId.getNamespace(),
@@ -348,7 +341,6 @@ public class OfflinePageBridge {
*/
@VisibleForTesting
public void deletePage(final ClientId clientId, Callback<Integer> callback) {
- assert mIsNativeOfflinePageModelLoaded;
ArrayList<ClientId> ids = new ArrayList<ClientId>();
ids.add(clientId);
@@ -357,7 +349,7 @@ public class OfflinePageBridge {
/**
* Deletes offline pages based on the list of provided client IDs. Calls the callback
- * when operation is complete. Requires that the model is already loaded.
+ * when operation is complete.
*
* @param clientIds A list of Client IDs for which the offline pages will be deleted.
* @param callback A callback that will be called once operation is completed.
@@ -375,13 +367,6 @@ public class OfflinePageBridge {
}
/**
- * Whether or not the underlying offline page model is loaded.
- */
- public boolean isOfflinePageModelLoaded() {
- return mIsNativeOfflinePageModelLoaded;
- }
-
- /**
* Retrieves the extra request header to reload the offline page.
* @param webContents Contents of the page to reload.
* @return The extra request header string.
@@ -432,14 +417,6 @@ public class OfflinePageBridge {
}
@CalledByNative
- protected void offlinePageModelLoaded() {
- mIsNativeOfflinePageModelLoaded = true;
- for (OfflinePageModelObserver observer : mObservers) {
- observer.offlinePageModelLoaded();
- }
- }
-
- @CalledByNative
protected void offlinePageAdded(OfflinePageItem addedPage) {
for (OfflinePageModelObserver observer : mObservers) {
observer.offlinePageAdded(addedPage);
@@ -454,7 +431,6 @@ public class OfflinePageBridge {
ThreadUtils.assertOnUiThread();
assert mNativeOfflinePageBridge != 0;
- mIsNativeOfflinePageModelLoaded = false;
mNativeOfflinePageBridge = 0;
// TODO(dewittj): Add a model destroyed method to the observer interface.

Powered by Google App Engine
This is Rietveld 408576698