[Offline Pages] Remove load state from public OfflinePageModel API.

chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 03d8041849adfcd82aa3a75ed0e6372a803507af..035aeb21db01e3d37b23aea47634816e1ee93848 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -558,7 +558,7 @@ public class NewTabPage
 
             // TODO(dewittj): Remove this code by making the NTP badging available after the NTP is
             // fully loaded.

[Marc Treib, 2016/12/13 10:11:02]

Hm. I'd be more comfortable with resolving this first, i.e. making the badges
appear asynchronously. The median load time is okay, but there is quite a long
tail. +bauerb WDYT?

[Bernhard Bauer, 2016/12/14 15:55:07]

What is the current state exactly? Don't we already make the badges appears
asynchronously, just via explicitly listening for when the model is loaded?

[Marc Treib, 2016/12/15 10:36:29]

IIUC, the current state is: If, during NTP creation, the OfflinePageModel isn't
loaded yet, then we just don't show offline badges.
After this CL, we would instead block until it is loaded. (Probably the NTP
itself would still load, but the tiles wouldn't.)
We don't (yet) have the plumbing to make the offline badges appear after the
initial load.

[Bernhard Bauer, 2016/12/15 17:48:00]

What does the code in
https://codereview.chromium.org/2564163002/diff/20001/chrome/android/java/src...
do then?

[vitaliii, 2016/12/16 08:28:04]

I agree with bauerb@. For example, if you download an article from NTP, its
offline badge appears on all open NTPs immediately. 

[Marc Treib, 2016/12/19 11:10:26]

That handles the offline badges on article suggestions. This here is for NTP
tiles (pka MostVisited). As far as I can tell, we still don't have the plumbing
here to add the badges after the tiles themselves.

-            if (offlinePageBridge == null || !offlinePageBridge.isOfflinePageModelLoaded()) {
+            if (offlinePageBridge == null) {
                 // Posting a task to avoid potential re-entrancy issues.
                 ThreadUtils.postOnUiThread(new Runnable() {
                     @Override