Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2563853002: Renamed 'type' to 'storage_type' in make_computed_style_base.py (Closed)
Patch Set: Rename Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py
diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
index 19a0e73828e2edbe76b38f55ba84262beec73371..b88d41328eb3194fe1659a7d2566d996da9eeb33 100755
--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
@@ -35,8 +35,8 @@ class Field(object):
self.name = kwargs.pop('name')
# Name of property field is for
self.property_name = kwargs.pop('property_name')
- # Field storage type
- self.type = kwargs.pop('type')
+ # Internal field storage type
+ self.storage_type = kwargs.pop('storage_type')
# Bits needed for storage
self.size = kwargs.pop('size')
# Default value for field
@@ -112,7 +112,7 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):
'inherited_flag',
name='m_' + field_name_suffix_lower,
property_name=property['name'],
- type='bool',
+ storage_type='bool',
size=1,
default_value='true',
getter_method_name=field_name_suffix_lower,
@@ -128,7 +128,7 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):
property_name=property['name'],
inherited=property['inherited'],
independent=property['independent'],
- type=type_name,
+ storage_type=type_name,
size=int(math.ceil(bits_needed)),
default_value=default_value,
getter_method_name=property_name_lower,
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698