Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2563593004: Restore clang-format formatting. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore clang-format formatting. As discussed in https://codereview.chromium.org/2556743002/, formatting is strange "because clang-format tries to align columns, even if there's only one row with aligned columns. I agree that this looks weird, and it sounds like it will be fixed." Removing the "// clang-format off" section as it has a cost since it requires developer to manually code format the region. BUG=None Committed: https://crrev.com/3a5f1623bc298bb5285819d285b37cc5da06e598 Cr-Commit-Position: refs/heads/master@{#437521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M tools/gn/xcode_writer.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sdefresne
To whoever will be faster, please review and send to CQ ;-)
4 years ago (2016-12-09 11:32:06 UTC) #4
Nico
lgtm
4 years ago (2016-12-09 12:28:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563593004/1
4 years ago (2016-12-09 12:28:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 12:33:36 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-09 12:35:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a5f1623bc298bb5285819d285b37cc5da06e598
Cr-Commit-Position: refs/heads/master@{#437521}

Powered by Google App Engine
This is Rietveld 408576698