Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2556743002: Clean formatting after http://crrev.com/2544803002/. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean formatting after http://crrev.com/2544803002/. As recommended, reformat the array definition (locally disable clang-format) and use range-base loop (as it works with plain arrays). BUG=None Committed: https://crrev.com/cdeaacd4acb0467526ea9a4ce27859f731417b6c Cr-Commit-Position: refs/heads/master@{#436902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M tools/gn/xcode_writer.cc View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years ago (2016-12-06 12:05:42 UTC) #4
Dirk Pranke
lgtm. If clang-format produced the prior formatting, that looks like a bug to me. Mind ...
4 years ago (2016-12-06 20:16:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556743002/1
4 years ago (2016-12-07 09:48:42 UTC) #9
sdefresne
On 2016/12/06 20:16:34, Dirk Pranke wrote: > lgtm. If clang-format produced the prior formatting, that ...
4 years ago (2016-12-07 09:48:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 09:52:44 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cdeaacd4acb0467526ea9a4ce27859f731417b6c Cr-Commit-Position: refs/heads/master@{#436902}
4 years ago (2016-12-07 09:55:08 UTC) #14
Nico
On 2016/12/06 20:16:34, Dirk Pranke wrote: > lgtm. If clang-format produced the prior formatting, that ...
4 years ago (2016-12-07 15:29:23 UTC) #15
Dirk Pranke
On 2016/12/07 15:29:23, Nico wrote: > Is the bug the excess of spaces, or that ...
4 years ago (2016-12-07 15:38:01 UTC) #16
Nico
On 2016/12/07 15:38:01, Dirk Pranke wrote: > On 2016/12/07 15:29:23, Nico wrote: > > Is ...
4 years ago (2016-12-08 19:55:18 UTC) #17
Dirk Pranke
4 years ago (2016-12-08 20:09:24 UTC) #18
Message was sent while issue was closed.
Agreed, I'm fine with (and prefer) weird formatting if there's a clang-format
bug on file for it.

Powered by Google App Engine
This is Rietveld 408576698