DevTools: Disallow console.log statements with eslint

DevTools: Disallow console.log statements with eslint

BUG=none

Committed: https://crrev.com/e2fef4b5dc2489adde994c2c08f28d2e89f665e8
Cr-Commit-Position: refs/heads/master@{#437681}

[einbinder, 2016-12-08 01:08:34]

einbinder@chromium.org changed reviewers:
+ willwilliam@google.com

[einbinder, 2016-12-08 01:08:34]

ptal

[einbinder, 2016-12-08 19:51:33]

einbinder@chromium.org changed reviewers:
+ chenwilliam@chromium.org
- willwilliam@google.com

[chenwilliam, 2016-12-08 20:00:23]

besides minor suggestions, lgtm

https://codereview.chromium.org/2563553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js
(right):

https://codereview.chromium.org/2563553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js:341:
console.time('time-stats: ' + callback.methodName);
maybe extract the label for console.time into a const?

https://codereview.chromium.org/2563553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js
(right):

https://codereview.chromium.org/2563553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js:26:
console.log('Test Done');  // eslint-disable-line no-console
Since it's a test harness, I think it's OK if we disable "no-console" check for
the entire file.

e.g. put this at top of file:
/* eslint-disable no-console */

[einbinder, 2016-12-09 01:16:05]

https://codereview.chromium.org/2563553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js
(right):

https://codereview.chromium.org/2563553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js:341:
console.time('time-stats: ' + callback.methodName);
On 2016/12/08 at 20:00:23, chenwilliam wrote:
> maybe extract the label for console.time into a const?

Done.

https://codereview.chromium.org/2563553002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js
(right):

https://codereview.chromium.org/2563553002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js:26:
console.log('Test Done');  // eslint-disable-line no-console
On 2016/12/08 at 20:00:23, chenwilliam wrote:
> Since it's a test harness, I think it's OK if we disable "no-console" check
for the entire file.
> 
> e.g. put this at top of file:
> /* eslint-disable no-console */

Done.

[einbinder, 2016-12-09 01:16:28]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2016-12-09 01:16:28]

@dgozman ptal

[dgozman, 2016-12-09 01:22:41]

Description was changed from

==========
DevTools: Disallow console.log and debugger statements with eslint

BUG=none
==========

to

==========
DevTools: Disallow console.log statements with eslint

BUG=none
==========

[dgozman, 2016-12-09 01:22:47]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-09 01:22:47]

lgtm

[dgozman, 2016-12-09 01:22:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
chenwilliam@chromium.org
Link to the patchset: https://codereview.chromium.org/2563553002/#ps40001
(title: "Comments")

[commit-bot: I haz the power, 2016-12-09 01:23:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 02:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 02:50:44]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[einbinder, 2016-12-09 21:23:32]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-12-09 21:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
chenwilliam@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2563553002/#ps60001
(title: "fix tests")

[commit-bot: I haz the power, 2016-12-09 21:24:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 23:17:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481318612341350,
"parent_rev": "c50122d6258dbb171c9c097b3d415069c7e66e50", "commit_rev":
"177026b5b7563bc7433d63429489be4fb5abc250"}

[commit-bot: I haz the power, 2016-12-09 23:18:12]

Description was changed from

==========
DevTools: Disallow console.log statements with eslint

BUG=none
==========

to

==========
DevTools: Disallow console.log statements with eslint

BUG=none

Review-Url: https://codereview.chromium.org/2563553002
==========

[commit-bot: I haz the power, 2016-12-09 23:18:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-12 14:57:59]

Description was changed from

==========
DevTools: Disallow console.log statements with eslint

BUG=none

Review-Url: https://codereview.chromium.org/2563553002
==========

to

==========
DevTools: Disallow console.log statements with eslint

BUG=none

Committed: https://crrev.com/e2fef4b5dc2489adde994c2c08f28d2e89f665e8
Cr-Commit-Position: refs/heads/master@{#437681}
==========

[commit-bot: I haz the power, 2016-12-12 14:58:03]

Patchset 4 (id:??) landed as
https://crrev.com/e2fef4b5dc2489adde994c2c08f28d2e89f665e8
Cr-Commit-Position: refs/heads/master@{#437681}