third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js - Issue 2563553002: DevTools: Disallow console.log statements with eslint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js

Issue 2563553002: DevTools: Disallow console.log statements with eslint (Closed)

Patch Set: fix tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/Widget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js

index 6595c34a484680f34fe1b11a52d46ba9eba8fcfc..3f15899cd9fdbd58a53623a2671563d2ffb6925c 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js

@@ -81,7 +81,7 @@ TimelineModel.TimelineProfileTree.buildTopDown = function(events, filters, start

}

parent.selfTime -= time;

if (parent.selfTime < 0) {

- console.log('Error: Negative self of ' + parent.selfTime, e);

+ console.error('Error: Negative self of ' + parent.selfTime, e);

parent.selfTime = 0;

}

if (e.endTime)