Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2563503003: Raising the char limit of KBShortcuts to 55 (Closed)

Created:
4 years ago by JJ
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Raising the char limit of KBShortcuts to 55 A few translators asked us to raise the limit. While some of them are asking for 60 characters, the highest we can go is 55 before it's nearly guranteed that the shortcuts will start to lose their optimal formatting. While working on this bug I also noticed that the zoom in shortcut didn't appear for some reason. Added a fix for this. BUG=672330 Committed: https://crrev.com/cbf3ad17dd80ab1d8428f62d5024a969823345f5 Cr-Commit-Position: refs/heads/master@{#437170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +19 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
JJ
PTAL when you have the chance.
4 years ago (2016-12-08 01:45:19 UTC) #3
Ted C
lgtm
4 years ago (2016-12-08 02:25:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563503003/1
4 years ago (2016-12-08 03:20:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 03:56:08 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-08 03:58:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbf3ad17dd80ab1d8428f62d5024a969823345f5
Cr-Commit-Position: refs/heads/master@{#437170}

Powered by Google App Engine
This is Rietveld 408576698