Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2563443002: [DevTools] Allow multiple clients to request remote locations. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Allow multiple clients to request remote locations. BUG=650398 Committed: https://crrev.com/f19f63c3a79de3ea1ceeddca5e33aac7009e7c8d Cr-Commit-Position: refs/heads/master@{#437446}

Patch Set 1 #

Patch Set 2 : fixed dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -38 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 5 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 6 chunks +80 lines, -37 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
dgozman
Take a look please.
4 years ago (2016-12-07 20:28:47 UTC) #2
pfeldman
lgtm
4 years ago (2016-12-08 02:01:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563443002/1
4 years ago (2016-12-08 02:45:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/329274)
4 years ago (2016-12-08 03:23:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563443002/40001
4 years ago (2016-12-09 01:26:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-09 03:03:33 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-09 03:05:52 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f19f63c3a79de3ea1ceeddca5e33aac7009e7c8d
Cr-Commit-Position: refs/heads/master@{#437446}

Powered by Google App Engine
This is Rietveld 408576698