Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4380)

Unified Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.h

Issue 2563443002: [DevTools] Allow multiple clients to request remote locations. (Closed)
Patch Set: fixed dcheck Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/chrome_devtools_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/chrome_devtools_manager_delegate.h
diff --git a/chrome/browser/devtools/chrome_devtools_manager_delegate.h b/chrome/browser/devtools/chrome_devtools_manager_delegate.h
index 56be98ac15564883a91b906697178d3771fe19c0..6dcaef263c9c6242ddad29abd461d8ea9d4b5ccb 100644
--- a/chrome/browser/devtools/chrome_devtools_manager_delegate.h
+++ b/chrome/browser/devtools/chrome_devtools_manager_delegate.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
#define CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
+#include <map>
#include <memory>
#include <set>
@@ -13,6 +14,7 @@
#include "chrome/browser/devtools/device/devtools_device_discovery.h"
#include "content/public/browser/devtools_agent_host_observer.h"
#include "content/public/browser/devtools_manager_delegate.h"
+#include "net/base/host_port_pair.h"
class DevToolsNetworkProtocolHandler;
@@ -28,6 +30,9 @@ class ChromeDevToolsManagerDelegate :
~ChromeDevToolsManagerDelegate() override;
private:
+ class HostData;
+ using RemoteLocations = std::set<net::HostPortPair>;
+
// content::DevToolsManagerDelegate implementation.
void Inspect(content::DevToolsAgentHost* agent_host) override;
base::DictionaryValue* HandleCommand(
@@ -46,6 +51,7 @@ class ChromeDevToolsManagerDelegate :
void DevToolsAgentHostDetached(
content::DevToolsAgentHost* agent_host) override;
+ void UpdateDeviceDiscovery();
void DevicesAvailable(
const DevToolsDeviceDiscovery::CompleteDevices& devices);
@@ -55,10 +61,12 @@ class ChromeDevToolsManagerDelegate :
base::DictionaryValue* params);
std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;
+ std::map<content::DevToolsAgentHost*, std::unique_ptr<HostData>> host_data_;
+
std::unique_ptr<AndroidDeviceManager> device_manager_;
std::unique_ptr<DevToolsDeviceDiscovery> device_discovery_;
content::DevToolsAgentHost::List remote_agent_hosts_;
- content::DevToolsAgentHost* remote_locations_requester_;
+ RemoteLocations remote_locations_;
DISALLOW_COPY_AND_ASSIGN(ChromeDevToolsManagerDelegate);
};
« no previous file with comments | « no previous file | chrome/browser/devtools/chrome_devtools_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698