Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2563423002: [Ignition] Fix incorrect arg evaluation order for some super calls. (Closed)

Created:
4 years ago by petermarshall
Modified:
4 years ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Ignition] Fix incorrect arg evaluation order for some super calls. The evaluation order of this argument was accidentally changed when the special-case was added for super calls with a final spread argument. Committed: https://crrev.com/375fc067b089e99b6bc2495a97938eab908f87aa Cr-Commit-Position: refs/heads/master@{#41633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
petermarshall
PTAL =]
4 years ago (2016-12-12 08:21:23 UTC) #4
Benedikt Meurer
lgtm Thanks Peter! LGTM
4 years ago (2016-12-12 08:22:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563423002/1
4 years ago (2016-12-12 08:23:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 08:45:19 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 08:46:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/375fc067b089e99b6bc2495a97938eab908f87aa
Cr-Commit-Position: refs/heads/master@{#41633}

Powered by Google App Engine
This is Rietveld 408576698