Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2563423002: [Ignition] Fix incorrect arg evaluation order for some super calls. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 9469fb58b8b657f7369dde57e3a5b06e070a5752..e78e4b22acff4684f3b1655d5b256dcc7a11fcd1 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -2518,8 +2518,8 @@ void BytecodeGenerator::VisitCallSuper(Call* expr) {
RegisterList args_regs =
register_allocator()->NewRegisterList(args->length() + 2);
builder()->MoveRegister(constructor, args_regs[0]);
- VisitForRegisterValue(super->new_target_var(), args_regs[1]);
VisitArguments(args, args_regs, 2);
+ VisitForRegisterValue(super->new_target_var(), args_regs[1]);
builder()->NewWithSpread(args_regs);
} else {
RegisterList args_regs =
« no previous file with comments | « no previous file | test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698