DevTools: add extension API to contribute trace events to timeline

DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to
    selectively enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate
    so that loader can be re-used outside of the panel;
- create a temp file in TimelineBackingStorage lazily, only when
    data are actually written there;
- changing TimelineController.startRecording() to accept options
    as a struct rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG=620066
Committed: https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c
Cr-Commit-Position: refs/heads/master@{#438734}

[caseq, 2016-12-13 02:02:55]

caseq@chromium.org changed reviewers:
+ alph@chromium.org, pfeldman@chromium.org

[caseq, 2016-12-13 02:09:37]

Description was changed from

==========
DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to selectively
    enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate so that
    loader can be re-used outside of the panel;
- changing TimelineController.startRecording() to accept options as a struct
    rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG=620066
==========

to

==========
DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to 
    selectively enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate
    so that loader can be re-used outside of the panel;
- create a temp file in TimelineBackingStorage lazily, only when
    data are actually written there;
- changing TimelineController.startRecording() to accept options
    as a struct rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG=620066
==========

[caseq, 2016-12-13 02:09:48]

Patchset #1 (id:1) has been deleted

[alph, 2016-12-13 02:35:54]

Can we have a screenshot of checkboxes

[alph, 2016-12-13 02:35:55]

Can we have a screenshot of checkboxes

[pfeldman, 2016-12-13 19:16:06]

I thought we were focusing on the polish bugs!

[alph, 2016-12-13 20:16:49]

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api.html
(right):

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api.html:58:
extension_startTimeline(() => extension_stopTimeline(() => { onTimelineReady();
}));
If you inline the last one, it'd look cool! ;-)
also you don't need {}

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
(right):

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js:319:
_onCompleteTraceSession(message) {
could you annotate plz

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionTraceProvider.js
(right):

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionTraceProvider.js:23:
var lastSessionId = String(++Extensions.ExtensionTraceProvider._lastSessionId);
nit: sessionId

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionTraceProvider.js:31:
/** @return {string} */
split it into three lines.

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js (right):

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:181: if (typeof
event.endTyime === 'number')
typo

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:186: if (typeof
event.endTyime === 'number')
typo

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:646: /** @type
{?function():!Promise.<?string>} */
drop dot

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:778: this._name
= '';
where it now gets the name from?

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
(right):

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js:361:
this._lastExtensionCount = 0;
_nextExtensionIndex or just _extensionCount

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:411:
static _settingForTraceProvider(traceProvider) {
annotate

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:420: /**
add line

https://codereview.chromium.org/2563383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:734:
tracingModel.adjustTime(this._model.minimumRecordTime() + (timeOffset / 1000) -
this._recordingStartTime);
this looks wrong. _minimumRecordTime is basically taken from the first event
(modulo some filtering) we find  in the main trace. It may not correlate to the
actual start time.

[caseq, 2016-12-13 22:59:01]

Review comments addressed, ptal.

[alph, 2016-12-14 00:17:32]

lgtm

https://codereview.chromium.org/2563383003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api.html
(right):

https://codereview.chromium.org/2563383003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api.html:49:
{"name": "Extension record X 1", "ts": start, "dur": step * 4, "ph": "X", args:
{},  "tid": tid, "pid": pid, "cat":"" },
put args in dquotes.

https://codereview.chromium.org/2563383003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
(right):

https://codereview.chromium.org/2563383003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js:320:
* @param {!object} message
nit: we use Object

[caseq, 2016-12-14 19:30:21]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-12-14 19:31:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 20:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:05:04]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[caseq, 2016-12-14 22:41:41]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-12-14 22:41:42]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2563383003/#ps60001
(title: "added ExtensionTracingSession")

[commit-bot: I haz the power, 2016-12-14 22:42:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 01:27:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[caseq, 2016-12-15 02:45:23]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-12-15 02:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2563383003/#ps80001
(title: "lint + new compiler warnings")

[commit-bot: I haz the power, 2016-12-15 02:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:20:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481769923362330,
"parent_rev": "144f88b2aef6f136d94688c3fdde301352c39d88", "commit_rev":
"557c31586281496c9b476ba59eff6a55c6dea974"}

[commit-bot: I haz the power, 2016-12-15 04:21:10]

Description was changed from

==========
DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to 
    selectively enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate
    so that loader can be re-used outside of the panel;
- create a temp file in TimelineBackingStorage lazily, only when
    data are actually written there;
- changing TimelineController.startRecording() to accept options
    as a struct rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG=620066
==========

to

==========
DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to 
    selectively enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate
    so that loader can be re-used outside of the panel;
- create a temp file in TimelineBackingStorage lazily, only when
    data are actually written there;
- changing TimelineController.startRecording() to accept options
    as a struct rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG=620066

Review-Url: https://codereview.chromium.org/2563383003
==========

[commit-bot: I haz the power, 2016-12-15 04:21:12]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-15 04:24:01]

Description was changed from

==========
DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to 
    selectively enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate
    so that loader can be re-used outside of the panel;
- create a temp file in TimelineBackingStorage lazily, only when
    data are actually written there;
- changing TimelineController.startRecording() to accept options
    as a struct rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG=620066

Review-Url: https://codereview.chromium.org/2563383003
==========

to

==========
DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to
    selectively enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate
    so that loader can be re-used outside of the panel;
- create a temp file in TimelineBackingStorage lazily, only when
    data are actually written there;
- changing TimelineController.startRecording() to accept options
    as a struct rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG=620066

Committed: https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c
Cr-Commit-Position: refs/heads/master@{#438734}
==========

[commit-bot: I haz the power, 2016-12-15 04:24:02]

Patchset 4 (id:??) landed as
https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c
Cr-Commit-Position: refs/heads/master@{#438734}