third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js - Issue 2563383003: DevTools: add extension API to contribute trace events to timeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js

Issue 2563383003: DevTools: add extension API to contribute trace events to timeline (Closed)

Patch Set: lint + new compiler warnings Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js

index e6180daa9e80eca41327b784a413c727436dcb24..8ad5a46982b034d38c60619acd5f87b2c2c96b02 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js

@@ -9,7 +9,7 @@

Timeline.TimelineLoader = class {

/**

* @param {!SDK.TracingModel} model

- * @param {!Timeline.TimelineLifecycleDelegate} delegate

+ * @param {!Timeline.LoaderClient} delegate

constructor(model, delegate) {

this._model = model;

@@ -46,7 +46,7 @@ Timeline.TimelineLoader = class {

/**

* @param {!SDK.TracingModel} model

* @param {string} url

- * @param {!Timeline.TimelineLifecycleDelegate} delegate

+ * @param {!Timeline.LoaderClient} delegate

* @return {!Timeline.TimelineLoader}

static loadFromURL(model, url, delegate) {