Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 2562903002: ozone: add NV12 to GetBufferFormatFromFourCCFormat (Closed)

Created:
4 years ago by gurchetansingh
Modified:
4 years ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: add NV12 to GetBufferFormatFromFourCCFormat crrev.com/2533163002 changed the internal format representation of the GbmBuffer class. The function used to convert back to the gfx::BufferFormat type, GetBufferFormatFromFourCCFormat, is missing NV12. This format gets passed from the ARC++ container to Chrome, so video playback isn't working on some platforms. Let's fix this by adding the format. BUG=b:33011213 TEST=Play Youtube App video on minnie R=dnicoara@chromium.org, dcastagna@chromium.org, tfiga@chromium.org, posciak@chromium.org Committed: https://crrev.com/05e587d647ad21227c035870a67237d918c3e080 Cr-Commit-Position: refs/heads/master@{#437608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/ozone/platform/drm/common/drm_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Daniele Castagna
Thank you! Just two nits. I think specifying just ui: or just ozone: in the ...
4 years ago (2016-12-09 02:35:29 UTC) #1
Daniele Castagna
On 2016/12/09 at 02:35:29, Daniele Castagna wrote: > Thank you! > Just two nits. I ...
4 years ago (2016-12-09 02:37:32 UTC) #2
gurchetansingh
On 2016/12/09 02:35:29, Daniele Castagna wrote: > Thank you! > Just two nits. I think ...
4 years ago (2016-12-09 04:50:32 UTC) #4
dnicoara
lgtm
4 years ago (2016-12-09 17:43:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562903002/1
4 years ago (2016-12-09 18:30:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 19:30:37 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05e587d647ad21227c035870a67237d918c3e080
Cr-Commit-Position: refs/heads/master@{#437608}

Powered by Google App Engine
This is Rietveld 408576698