Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Issue 2562643005: Remove bad comment in HasSignBit (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
scottmg
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove bad comment in HasSignBit Remove a bad comment left behind from crrev.com/437342 TBR=scottmg R=scottmg NOTRY=true Committed: https://crrev.com/6b15c686879f6747935a517f74f579f7ae46d797 Cr-Commit-Position: refs/heads/master@{#437416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/numerics/safe_math_impl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
scottmg
lgtm
4 years ago (2016-12-08 23:00:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562643005/1
4 years ago (2016-12-08 23:01:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 01:40:00 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b15c686879f6747935a517f74f579f7ae46d797 Cr-Commit-Position: refs/heads/master@{#437416}
4 years ago (2016-12-09 01:43:03 UTC) #9
jschuh
4 years ago (2016-12-09 17:35:24 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2559183004/ by jschuh@chromium.org.

The reason for reverting is: The original change was not actually a performance
improvement..

Powered by Google App Engine
This is Rietveld 408576698