Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2559183004: Revert of Remove bad comment in HasSignBit (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
scottmg
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove bad comment in HasSignBit (patchset #1 id:1 of https://codereview.chromium.org/2562643005/ ) Reason for revert: The original change was not actually a performance improvement. Original issue's description: > Remove bad comment in HasSignBit > > Remove a bad comment left behind from crrev.com/437342 > TBR=scottmg > R=scottmg > NOTRY=true > > Committed: https://crrev.com/6b15c686879f6747935a517f74f579f7ae46d797 > Cr-Commit-Position: refs/heads/master@{#437416} TBR=scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/28c208fcaf6848fc6b429bfeb362de83383302fd Cr-Commit-Position: refs/heads/master@{#437579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/numerics/safe_math_impl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jschuh
Created Revert of Remove bad comment in HasSignBit
4 years ago (2016-12-09 17:35:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559183004/1
4 years ago (2016-12-09 17:35:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 17:38:01 UTC) #6
scottmg
lgtm
4 years ago (2016-12-09 18:25:09 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-12 14:35:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28c208fcaf6848fc6b429bfeb362de83383302fd
Cr-Commit-Position: refs/heads/master@{#437579}

Powered by Google App Engine
This is Rietveld 408576698