Updates SessionMessage to ConnectionMessage.

Updates SessionMessage to ConnectionMessage.

Merges PresentationMessageTypes ARRAY_BUFFER/BLOB into BINARY.

BUG=629151
Committed: https://crrev.com/44204ce5f5a841d13d26e89abbc93cd4db181425
Cr-Commit-Position: refs/heads/master@{#438409}

[CJ, 2016-12-08 01:50:03]

lethalantidote@chromium.org changed reviewers:
+ imcheng@chromium.org, mfoltz@chromium.org

[CJ, 2016-12-08 01:50:03]

Let me know what you think. Wasn't sure if I should change other references to
Session to Connection as well. Let me know.

[mark a. foltz, 2016-12-09 06:10:16]

LGTM

Looks great!  Thanks.

You can add dcheng@ to review the .mojom and avi@ to review content/public.

[CJ, 2016-12-13 02:17:14]

Description was changed from

==========
Updates SessionMessage to ConnectionMessage.

Merges PresentationMessageTypes ARRAY_BUFFER/BLOB into BINARY.

BUG=629151
==========

to

==========
Updates SessionMessage to ConnectionMessage.

Merges PresentationMessageTypes ARRAY_BUFFER/BLOB into BINARY.

BUG=629151
==========

[CJ, 2016-12-13 02:17:14]

lethalantidote@chromium.org changed reviewers:
+ avi@chromium.org, dcheng@chromium.org

[CJ, 2016-12-13 02:17:40]

On 2016/12/09 06:10:16, mark a. foltz wrote:
> LGTM
> 
> Looks great!  Thanks.
> 
> You can add dcheng@ to review the .mojom and avi@ to review content/public.

+ dcheng@ for .mojom
+ avi@ for content/public.

[Avi (use Gerrit), 2016-12-13 02:23:53]

content/public lgtm

https://codereview.chromium.org/2562603002/diff/1/content/public/browser/pres...
File content/public/browser/presentation_service_delegate.h (right):

https://codereview.chromium.org/2562603002/diff/1/content/public/browser/pres...
content/public/browser/presentation_service_delegate.h:33: void(const
ScopedVector<content::PresentationConnectionMessage>&, bool)>;
Can you follow up with a removal of ScopedVector in favor of vector<unique_ptr>?
That's http://crbug.com/554289 .

[CJ, 2016-12-13 02:26:31]

On 2016/12/13 02:23:53, Avi wrote:
> content/public lgtm
> 
>
https://codereview.chromium.org/2562603002/diff/1/content/public/browser/pres...
> File content/public/browser/presentation_service_delegate.h (right):
> 
>
https://codereview.chromium.org/2562603002/diff/1/content/public/browser/pres...
> content/public/browser/presentation_service_delegate.h:33: void(const
> ScopedVector<content::PresentationConnectionMessage>&, bool)>;
> Can you follow up with a removal of ScopedVector in favor of
vector<unique_ptr>?
> That's http://crbug.com/554289 .

Sure, I'll give it a go in a CL after this :)

[dcheng, 2016-12-13 08:25:14]

https://codereview.chromium.org/2562603002/diff/1/content/browser/presentatio...
File content/browser/presentation/presentation_service_impl.cc (right):

https://codereview.chromium.org/2562603002/diff/1/content/browser/presentatio...
content/browser/presentation/presentation_service_impl.cc:48:
DCHECK(input->data);
I've mentioned this previously, but any chance this this will be typemapped
soon? It's been a few months, and it would be nice to clean this up to make
future security reviewers easier.

https://codereview.chromium.org/2562603002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/presentation/presentation.mojom
(right):

https://codereview.chromium.org/2562603002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/presentation/presentation.mojom:50:
// Used when message type is BINARY.
Please add a TODO to make this a mojo union (I'd suggest
https://crbug.com/632623 as a reasonable umbrella bug for this)

[CJ, 2016-12-13 22:05:36]

https://codereview.chromium.org/2562603002/diff/1/content/browser/presentatio...
File content/browser/presentation/presentation_service_impl.cc (right):

https://codereview.chromium.org/2562603002/diff/1/content/browser/presentatio...
content/browser/presentation/presentation_service_impl.cc:48:
DCHECK(input->data);
On 2016/12/13 08:25:14, dcheng wrote:
> I've mentioned this previously, but any chance this this will be typemapped
> soon? It's been a few months, and it would be nice to clean this up to make
> future security reviewers easier.

I'm new, so this is the first I've heard of this. Could you explain more? I
wouldn't mind doing it in the next CL if that's ok.

https://codereview.chromium.org/2562603002/diff/1/content/public/browser/pres...
File content/public/browser/presentation_service_delegate.h (right):

https://codereview.chromium.org/2562603002/diff/1/content/public/browser/pres...
content/public/browser/presentation_service_delegate.h:33: void(const
ScopedVector<content::PresentationConnectionMessage>&, bool)>;
On 2016/12/13 02:23:53, Avi wrote:
> Can you follow up with a removal of ScopedVector in favor of
vector<unique_ptr>?
> That's http://crbug.com/554289 .

Done.

https://codereview.chromium.org/2562603002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/modules/presentation/presentation.mojom
(right):

https://codereview.chromium.org/2562603002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/modules/presentation/presentation.mojom:50:
// Used when message type is BINARY.
On 2016/12/13 08:25:14, dcheng wrote:
> Please add a TODO to make this a mojo union (I'd suggest
> https://crbug.com/632623 as a reasonable umbrella bug for this)

Done.
Ah is this related to your other comment?

[dcheng, 2016-12-13 22:39:13]

mojo lgtm

https://codereview.chromium.org/2562603002/diff/1/content/browser/presentatio...
File content/browser/presentation/presentation_service_impl.cc (right):

https://codereview.chromium.org/2562603002/diff/1/content/browser/presentatio...
content/browser/presentation/presentation_service_impl.cc:48:
DCHECK(input->data);
On 2016/12/13 22:05:35, CJ wrote:
> On 2016/12/13 08:25:14, dcheng wrote:
> > I've mentioned this previously, but any chance this this will be typemapped
> > soon? It's been a few months, and it would be nice to clean this up to make
> > future security reviewers easier.
> 
> I'm new, so this is the first I've heard of this. Could you explain more? I
> wouldn't mind doing it in the next CL if that's ok. 

Yeah, a followup is fine, I just wanted to make sure this was on the radar: we
want to try to encourage idiomatic use of Mojo to make things easier for
security reviewers. One of the idioms is using something called StructTraits [1]
to have a consistent interface for validating Mojo IPC.

[1] https://www.chromium.org/developers/design-documents/mojo/type-mapping

[CJ, 2016-12-13 23:04:27]

The CQ bit was checked by lethalantidote@chromium.org

[CJ, 2016-12-13 23:04:28]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2562603002/#ps20001
(title: "Addresses dcheng's #9 comments.")

[commit-bot: I haz the power, 2016-12-13 23:05:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 23:20:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[CJ, 2016-12-13 23:41:33]

The CQ bit was checked by lethalantidote@chromium.org

[CJ, 2016-12-13 23:41:34]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
avi@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2562603002/#ps40001
(title: "Updates test.")

[commit-bot: I haz the power, 2016-12-13 23:42:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:55:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 23:55:49]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[CJ, 2016-12-14 00:19:09]

The CQ bit was checked by lethalantidote@chromium.org

[CJ, 2016-12-14 00:19:09]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
avi@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2562603002/#ps60001
(title: "More edits to test.")

[commit-bot: I haz the power, 2016-12-14 00:19:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 03:11:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481674749403780,
"parent_rev": "6299b729b0950f760a4a8f0889d1e7982f783c06", "commit_rev":
"3dc4c2d61721698312d48b253b1271f5c6ec90f2"}

[commit-bot: I haz the power, 2016-12-14 03:12:22]

Description was changed from

==========
Updates SessionMessage to ConnectionMessage.

Merges PresentationMessageTypes ARRAY_BUFFER/BLOB into BINARY.

BUG=629151
==========

to

==========
Updates SessionMessage to ConnectionMessage.

Merges PresentationMessageTypes ARRAY_BUFFER/BLOB into BINARY.

BUG=629151

Review-Url: https://codereview.chromium.org/2562603002
==========

[commit-bot: I haz the power, 2016-12-14 03:12:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 03:14:10]

Description was changed from

==========
Updates SessionMessage to ConnectionMessage.

Merges PresentationMessageTypes ARRAY_BUFFER/BLOB into BINARY.

BUG=629151

Review-Url: https://codereview.chromium.org/2562603002
==========

to

==========
Updates SessionMessage to ConnectionMessage.

Merges PresentationMessageTypes ARRAY_BUFFER/BLOB into BINARY.

BUG=629151

Committed: https://crrev.com/44204ce5f5a841d13d26e89abbc93cd4db181425
Cr-Commit-Position: refs/heads/master@{#438409}
==========

[commit-bot: I haz the power, 2016-12-14 03:14:11]

Patchset 4 (id:??) landed as
https://crrev.com/44204ce5f5a841d13d26e89abbc93cd4db181425
Cr-Commit-Position: refs/heads/master@{#438409}