Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Issue 2562603002: Updates SessionMessage to ConnectionMessage. (Closed)
Patch Set: More edits to test. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/presentation/presentation_dispatcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/modules/presentation/presentation.mojom
diff --git a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
index ec0f087bcb93904d144e91c6bc7da79d8b9e011e..847ed6cbc1b607903bca79599d44d55fd373a0ea 100644
--- a/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
+++ b/third_party/WebKit/public/platform/modules/presentation/presentation.mojom
@@ -40,15 +40,16 @@ struct PresentationError {
enum PresentationMessageType {
TEXT,
- ARRAY_BUFFER,
- BLOB,
+ BINARY,
};
-struct SessionMessage {
+struct ConnectionMessage {
PresentationMessageType type;
// Used when message type is TEXT.
string? message;
- // Used when message type is ARRAY_BUFFER or BLOB.
+ // Used when message type is BINARY.
+ // TODO(lethalantidote): Make this a mojo union.
+ // See https://crbug.com/632623.
array<uint8>? data;
};
@@ -95,8 +96,8 @@ interface PresentationService {
// The false in the result callback notifies the renderer to stop sending
// the send requests and invalidate all pending requests. This occurs
// for eg., when frame is deleted or navigated away.
- SendSessionMessage(PresentationSessionInfo sessionInfo,
- SessionMessage message_request) => (bool success);
+ SendConnectionMessage(PresentationSessionInfo sessionInfo,
+ ConnectionMessage message_request) => (bool success);
// Called when close() is called by the frame.
CloseConnection(url.mojom.Url presentation_url, string presentation_id);
@@ -106,9 +107,9 @@ interface PresentationService {
// Starts listening for messages for session with |sessionInfo|.
// Messages will be received in
- // PresentationServiceClient::OnSessionMessagesReceived.
+ // PresentationServiceClient::OnConnectionMessagesReceived.
// This is called after a presentation session is created.
- ListenForSessionMessages(PresentationSessionInfo sessionInfo);
+ ListenForConnectionMessages(PresentationSessionInfo sessionInfo);
};
interface PresentationServiceClient {
@@ -135,9 +136,9 @@ interface PresentationServiceClient {
PresentationConnectionCloseReason reason,
string message);
- // See PresentationService::ListenForSessionMessages.
- OnSessionMessagesReceived(PresentationSessionInfo sessionInfo,
- array<SessionMessage> messages);
+ // See PresentationService::ListenForConnectionMessages.
+ OnConnectionMessagesReceived(PresentationSessionInfo sessionInfo,
+ array<ConnectionMessage> messages);
// See PresentationService::SetDefaultPresentationURL.
OnDefaultSessionStarted(PresentationSessionInfo sessionInfo);
« no previous file with comments | « content/renderer/presentation/presentation_dispatcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698