Generalize WebContentsObserver::SecurityStyleChanged

content/browser/devtools/protocol/security_handler.cc

Index: content/browser/devtools/protocol/security_handler.cc
diff --git a/content/browser/devtools/protocol/security_handler.cc b/content/browser/devtools/protocol/security_handler.cc
index d3efa82257fbed81b3698de5f86068e161e2816d..f21ff9f9453a470f342bc6bfe42b94dcf40433ea 100644
--- a/content/browser/devtools/protocol/security_handler.cc
+++ b/content/browser/devtools/protocol/security_handler.cc
@@ -75,13 +75,9 @@ void SecurityHandler::AttachToRenderFrameHost() {
   WebContents* web_contents = WebContents::FromRenderFrameHost(host_);
   WebContentsObserver::Observe(web_contents);
 
-  // Send an initial SecurityStyleChanged event.
+  // Send an initial DidChangeVisibleSecurityState event.
   DCHECK(enabled_);
-  SecurityStyleExplanations security_style_explanations;
-  blink::WebSecurityStyle security_style =
-      web_contents->GetDelegate()->GetSecurityStyle(
-          web_contents, &security_style_explanations);
-  SecurityStyleChanged(security_style, security_style_explanations);
+  DidChangeVisibleSecurityState();
 }
 
 void SecurityHandler::SetRenderFrameHost(RenderFrameHost* host) {
@@ -90,11 +86,14 @@ void SecurityHandler::SetRenderFrameHost(RenderFrameHost* host) {
     AttachToRenderFrameHost();
 }
 
-void SecurityHandler::SecurityStyleChanged(
-    blink::WebSecurityStyle security_style,
-    const SecurityStyleExplanations& security_style_explanations) {
+void SecurityHandler::DidChangeVisibleSecurityState() {
   DCHECK(enabled_);
 
+  SecurityStyleExplanations security_style_explanations;
+  blink::WebSecurityStyle security_style =
+      web_contents()->GetDelegate()->GetSecurityStyle(

[boliu, 2016/12/08 05:11:30]

there's prior example with ShowCertificateViewerInDevTools below, but this
really is abusing WebContentsDelegate

it's *WebContents*Delegate, only WebContentsImpl should call stuff on it, not
other random things, in content or otherwise

actually in this case, since these two methods that's called *only* by devtools,
there probably should be a separate interface for these

follow up clean up I guess.. +dgozman

[dgozman, 2016/12/08 19:07:49]

Feel free to discuss this with content API owners:
https://codereview.chromium.org/1325023002#msg9

+          web_contents(), &security_style_explanations);
+
   const std::string security_state =
       SecurityStyleToProtocolSecurityState(security_style);