Generalize WebContentsObserver::SecurityStyleChanged

content/browser/devtools/protocol/security_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/protocol/security_handler.h"
 
 #include <string>
 
 #include "content/browser/devtools/protocol/devtools_protocol_dispatcher.h"
 #include "content/public/browser/navigation_controller.h"
@@ skipping 57 matching lines @@
 
 void SecurityHandler::SetClient(std::unique_ptr<Client> client) {
   client_.swap(client);
 }
 
 void SecurityHandler::AttachToRenderFrameHost() {
   DCHECK(host_);
   WebContents* web_contents = WebContents::FromRenderFrameHost(host_);
   WebContentsObserver::Observe(web_contents);
 
-  // Send an initial SecurityStyleChanged event.
+  // Send an initial DidChangeVisibleSecurityState event.
   DCHECK(enabled_);
-  SecurityStyleExplanations security_style_explanations;
-  blink::WebSecurityStyle security_style =
-      web_contents->GetDelegate()->GetSecurityStyle(
-          web_contents, &security_style_explanations);
-  SecurityStyleChanged(security_style, security_style_explanations);
+  DidChangeVisibleSecurityState();
 }
 
 void SecurityHandler::SetRenderFrameHost(RenderFrameHost* host) {
   host_ = host;
   if (enabled_ && host_)
     AttachToRenderFrameHost();
 }
 
-void SecurityHandler::SecurityStyleChanged(
-    blink::WebSecurityStyle security_style,
-    const SecurityStyleExplanations& security_style_explanations) {
+void SecurityHandler::DidChangeVisibleSecurityState() {
   DCHECK(enabled_);
 
+  SecurityStyleExplanations security_style_explanations;
+  blink::WebSecurityStyle security_style =
+      web_contents()->GetDelegate()->GetSecurityStyle(

[boliu, 2016/12/08 05:11:30]

there's prior example with ShowCertificateViewerInDevTools below, but this
really is abusing WebContentsDelegate

it's *WebContents*Delegate, only WebContentsImpl should call stuff on it, not
other random things, in content or otherwise

actually in this case, since these two methods that's called *only* by devtools,
there probably should be a separate interface for these

follow up clean up I guess.. +dgozman

[dgozman, 2016/12/08 19:07:49]

Feel free to discuss this with content API owners:
https://codereview.chromium.org/1325023002#msg9

+          web_contents(), &security_style_explanations);
+
   const std::string security_state =
       SecurityStyleToProtocolSecurityState(security_style);
 
   std::vector<scoped_refptr<SecurityStateExplanation>> explanations;
   AddExplanations(kSecurityStateInsecure,
                   security_style_explanations.broken_explanations,
                   &explanations);
   AddExplanations(kSecurityStateNeutral,
                   security_style_explanations.unauthenticated_explanations,
                   &explanations);
@@ skipping 51 matching lines @@
   if (!certificate)
     return Response::InternalError("Could not find certificate");
   web_contents->GetDelegate()->ShowCertificateViewerInDevTools(
       web_contents, certificate);
   return Response::OK();
 }
 
 }  // namespace security
 }  // namespace devtools
 }  // namespace content