Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1325023002: DevTools: [security] allow opening certificate viewer from devtools (chrome) (Closed)

Created:
5 years, 3 months ago by pfeldman
Modified:
5 years, 3 months ago
Reviewers:
dgozman, jam, sky
CC:
chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [security] allow opening certificate viewer from devtools (chrome) BUG=506468 Committed: https://crrev.com/61aa8a159dcf44624c6c5a61ac62d91c1788e6af Cr-Commit-Position: refs/heads/master@{#347259}

Patch Set 1 : #

Patch Set 2 : review comments addressed #

Patch Set 3 : #

Patch Set 4 : moved into wcd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_window.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/network_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/network_handler.cc View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
pfeldman
5 years, 3 months ago (2015-09-01 23:43:36 UTC) #3
pfeldman
5 years, 3 months ago (2015-09-02 00:58:51 UTC) #4
dgozman
lgtm
5 years, 3 months ago (2015-09-02 18:01:15 UTC) #5
pfeldman
+jam for owners review of content/public.
5 years, 3 months ago (2015-09-02 18:28:57 UTC) #7
jam
On 2015/09/02 18:28:57, pfeldman wrote: > +jam for owners review of content/public. why isn't this ...
5 years, 3 months ago (2015-09-03 15:22:58 UTC) #9
pfeldman
Wanted to keep it next to SelectClientCertificate for consistency. I can see a TODO there, ...
5 years, 3 months ago (2015-09-03 16:19:07 UTC) #10
pfeldman
@jam, moved into web_contents_delegate, ptal.
5 years, 3 months ago (2015-09-03 20:27:36 UTC) #11
jam
lgtm
5 years, 3 months ago (2015-09-03 20:44:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325023002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325023002/80001
5 years, 3 months ago (2015-09-03 21:25:54 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 3 months ago (2015-09-03 22:08:24 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 22:09:18 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/61aa8a159dcf44624c6c5a61ac62d91c1788e6af
Cr-Commit-Position: refs/heads/master@{#347259}

Powered by Google App Engine
This is Rietveld 408576698