Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 2562373002: Revert of Disable v8.browsing_desktop & v8.browsing_desktop_ignition on Win Perf bots (Closed)

Created:
4 years ago by ulan
Modified:
4 years ago
Reviewers:
Zhen Wang, martiniss
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable v8.browsing_desktop & v8.browsing_desktop_ignition on Win Perf bots (patchset #1 id:1 of https://codereview.chromium.org/2401253002/ ) Reason for revert: Speculatively re-enabling to see if it still fails on the bots. Original issue's description: > Disable v8.browsing_desktop & v8.browsing_desktop_ignition on Win Perf bots > > TBR=nednguyen@google.com > BUG=chromium:654209 > > Committed: https://crrev.com/1a039dd675016be7597d84dcef408e1b786a56d4 > Cr-Commit-Position: refs/heads/master@{#424086} TBR=zhenw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:654209 Committed: https://crrev.com/a79e188e6bde19959c4517ee0e9408f95594b405 Cr-Commit-Position: refs/heads/master@{#437875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/v8_browsing.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ulan
Created Revert of Disable v8.browsing_desktop & v8.browsing_desktop_ignition on Win Perf bots
4 years ago (2016-12-12 13:05:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562373002/1
4 years ago (2016-12-12 13:06:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 15:16:05 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a79e188e6bde19959c4517ee0e9408f95594b405 Cr-Commit-Position: refs/heads/master@{#437875}
4 years ago (2016-12-12 15:18:21 UTC) #8
martiniss
This appears to still be failing. See https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_Perf%2F69%2F%2B%2Frecipes%2Fsteps%2Fv8.browsing_desktop_on__102b__GPU_on_Windows_on_Windows-2008ServerR2-SP1%2F0%2Fstdout
4 years ago (2016-12-12 21:35:42 UTC) #10
ulan
4 years ago (2016-12-13 11:12:28 UTC) #11
Message was sent while issue was closed.
On 2016/12/12 21:35:42, martiniss wrote:
> This appears to still be failing. See
>
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_Perf...

That failure is unrelated to the 654209. It is in a new story
browse:search:google, which is failing in all win bots.

Powered by Google App Engine
This is Rietveld 408576698