Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: tools/perf/benchmarks/v8_browsing.py

Issue 2562373002: Revert of Disable v8.browsing_desktop & v8.browsing_desktop_ignition on Win Perf bots (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from benchmarks import v8_helper 7 from benchmarks import v8_helper
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import chrome_trace_config 10 from telemetry.timeline import chrome_trace_config
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 return possible_browser.platform.GetDeviceTypeName() != 'Desktop' 98 return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
99 99
100 100
101 class _V8MobileBrowsingBenchmark(_V8BrowsingBenchmark): 101 class _V8MobileBrowsingBenchmark(_V8BrowsingBenchmark):
102 102
103 @classmethod 103 @classmethod
104 def ShouldDisable(cls, possible_browser): 104 def ShouldDisable(cls, possible_browser):
105 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' 105 return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
106 106
107 107
108 @benchmark.Disabled('win') # http://crbug.com/654209
109 class V8DesktopBrowsingBenchmark(_V8DesktopBrowsingBenchmark): 108 class V8DesktopBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
110 PLATFORM = 'desktop' 109 PLATFORM = 'desktop'
111 TEST_SUFFIX = '' 110 TEST_SUFFIX = ''
112 111
113 112
114 @benchmark.Disabled('reference') # http://crbug.com/628631 113 @benchmark.Disabled('reference') # http://crbug.com/628631
115 class V8MobileBrowsingBenchmark(_V8MobileBrowsingBenchmark): 114 class V8MobileBrowsingBenchmark(_V8MobileBrowsingBenchmark):
116 PLATFORM = 'mobile' 115 PLATFORM = 'mobile'
117 TEST_SUFFIX = '' 116 TEST_SUFFIX = ''
118 117
119 118
120 @benchmark.Disabled('win') # http://crbug.com/654209
121 class V8DesktopIgnitionBrowsingBenchmark(_V8DesktopBrowsingBenchmark): 119 class V8DesktopIgnitionBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
122 PLATFORM = 'desktop' 120 PLATFORM = 'desktop'
123 TEST_SUFFIX = '_ignition' 121 TEST_SUFFIX = '_ignition'
124 122
125 def SetExtraBrowserOptions(self, options): 123 def SetExtraBrowserOptions(self, options):
126 super(V8DesktopIgnitionBrowsingBenchmark, self).SetExtraBrowserOptions( 124 super(V8DesktopIgnitionBrowsingBenchmark, self).SetExtraBrowserOptions(
127 options) 125 options)
128 v8_helper.EnableIgnition(options) 126 v8_helper.EnableIgnition(options)
129 127
130 128
131 @benchmark.Disabled('reference') # http://crbug.com/628631 129 @benchmark.Disabled('reference') # http://crbug.com/628631
132 class V8MobileIgnitionBrowsingBenchmark(_V8MobileBrowsingBenchmark): 130 class V8MobileIgnitionBrowsingBenchmark(_V8MobileBrowsingBenchmark):
133 PLATFORM = 'mobile' 131 PLATFORM = 'mobile'
134 TEST_SUFFIX = '_ignition' 132 TEST_SUFFIX = '_ignition'
135 133
136 def SetExtraBrowserOptions(self, options): 134 def SetExtraBrowserOptions(self, options):
137 super(V8MobileIgnitionBrowsingBenchmark, self).SetExtraBrowserOptions( 135 super(V8MobileIgnitionBrowsingBenchmark, self).SetExtraBrowserOptions(
138 options) 136 options)
139 v8_helper.EnableIgnition(options) 137 v8_helper.EnableIgnition(options)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698