Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2562273003: Disable layout optimization when column height may be non-uniform. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable layout optimization when column height may be non-uniform. We have no way of telling what changes beyond the first column break, so if we cannot guarantee that the column height *is* and *was* non-uniform, we need to re-lay out children that may stretch into the unknown. Committed: https://crrev.com/7b7e09562d5bbf9886f73e32f45864af2fde04ef Cr-Commit-Position: refs/heads/master@{#437928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/multicol/dynamic/change-second-row-height.html View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
mstensho (USE GERRIT)
Found while working on bug 672088.
4 years ago (2016-12-12 18:26:27 UTC) #6
eae
Nice catch LGTM
4 years ago (2016-12-12 18:29:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562273003/1
4 years ago (2016-12-12 18:54:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562273003/1
4 years ago (2016-12-12 19:30:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 22:18:13 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 22:19:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b7e09562d5bbf9886f73e32f45864af2fde04ef
Cr-Commit-Position: refs/heads/master@{#437928}

Powered by Google App Engine
This is Rietveld 408576698