Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

Issue 2562273003: Disable layout optimization when column height may be non-uniform. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved. 2 * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above 8 * 1. Redistributions of source code must retain the above
9 * copyright notice, this list of conditions and the following 9 * copyright notice, this list of conditions and the following
10 * disclaimer. 10 * disclaimer.
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 // is expected to be at the exact top of a column that's known to not have 134 // is expected to be at the exact top of a column that's known to not have
135 // enough space for |contentLogicalHeight|. This method is called when the 135 // enough space for |contentLogicalHeight|. This method is called when the
136 // current column is too short to fit the content, in the hope that there 136 // current column is too short to fit the content, in the hope that there
137 // exists one that's tall enough further ahead. If no such column can be 137 // exists one that's tall enough further ahead. If no such column can be
138 // found, |flowThreadOffset| will be returned. 138 // found, |flowThreadOffset| will be returned.
139 LayoutUnit nextLogicalTopForUnbreakableContent( 139 LayoutUnit nextLogicalTopForUnbreakableContent(
140 LayoutUnit flowThreadOffset, 140 LayoutUnit flowThreadOffset,
141 LayoutUnit contentLogicalHeight) const; 141 LayoutUnit contentLogicalHeight) const;
142 142
143 virtual bool isPageLogicalHeightKnown() const { return true; } 143 virtual bool isPageLogicalHeightKnown() const { return true; }
144 virtual bool mayHaveNonUniformPageLogicalHeight() const = 0;
144 bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; } 145 bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }
145 146
146 // Return the visual bounding box based on the supplied flow-thread bounding 147 // Return the visual bounding box based on the supplied flow-thread bounding
147 // box. Both rectangles are completely physical in terms of writing mode. 148 // box. Both rectangles are completely physical in terms of writing mode.
148 LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox) const; 149 LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox) const;
149 150
150 // Convert a logical position in the flow thread coordinate space to a logical 151 // Convert a logical position in the flow thread coordinate space to a logical
151 // position in the containing coordinate space. 152 // position in the containing coordinate space.
152 void flowThreadToContainingCoordinateSpace(LayoutUnit& blockPosition, 153 void flowThreadToContainingCoordinateSpace(LayoutUnit& blockPosition,
153 LayoutUnit& inlinePosition) const; 154 LayoutUnit& inlinePosition) const;
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 struct ValueToString<LayoutMultiColumnSet*> { 203 struct ValueToString<LayoutMultiColumnSet*> {
203 static String toString(const LayoutMultiColumnSet* value) { 204 static String toString(const LayoutMultiColumnSet* value) {
204 return String::format("%p", value); 205 return String::format("%p", value);
205 } 206 }
206 }; 207 };
207 #endif 208 #endif
208 209
209 } // namespace blink 210 } // namespace blink
210 211
211 #endif // LayoutFlowThread_h 212 #endif // LayoutFlowThread_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698