Make AudioTimestampHelper::TimeToFrames() more accurate

Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of AudioTimestampHelper::TimeToFrames() more accurate.

Before, this translation was eating frames on each call, leading to significant loss of accuracy in AudioConverter: initial delay of 0.011609s at 'AudioRendererMixer::Render' changed to 0.011587s 'AudioRendererMixerInput::ProvideInput'.

BUG=619533
Committed: https://crrev.com/900df16a521d74065ed5c566e563eb29d317ae91
Cr-Commit-Position: refs/heads/master@{#438464}

[Mikhail, 2016-12-13 15:28:26]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 15:28:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-12-13 15:30:00]

Description was changed from

==========
Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of
AudioTimestampHelper::TimeToFrames() more accurate.

Before this translation was eating frames on each call, leading to significant
loss of accuracy in AudioConverter: initial delay of 0.011609s at
'AudioRendererMixer::Render' changed to 0.011587s
'AudioRendererMixerInput::ProvideInput'.

BUG=619533
==========

to

==========
Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of
AudioTimestampHelper::TimeToFrames() more accurate.

Before this translation was eating frames on each call, leading to significant
loss of accuracy in AudioConverter: initial delay of 0.011609s at
'AudioRendererMixer::Render' changed to 0.011587s
'AudioRendererMixerInput::ProvideInput'.

BUG=619533
==========

[Mikhail, 2016-12-13 15:30:00]

mikhail.pozdnyakov@intel.com changed reviewers:
+ chcunningham@chromium.org

[Mikhail, 2016-12-13 15:41:37]

Description was changed from

==========
Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of
AudioTimestampHelper::TimeToFrames() more accurate.

Before this translation was eating frames on each call, leading to significant
loss of accuracy in AudioConverter: initial delay of 0.011609s at
'AudioRendererMixer::Render' changed to 0.011587s
'AudioRendererMixerInput::ProvideInput'.

BUG=619533
==========

to

==========
Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of
AudioTimestampHelper::TimeToFrames() more accurate.

Before, this translation was eating frames on each call, leading to significant
loss of accuracy in AudioConverter: initial delay of 0.011609s at
'AudioRendererMixer::Render' changed to 0.011587s
'AudioRendererMixerInput::ProvideInput'.

BUG=619533
==========

[commit-bot: I haz the power, 2016-12-13 15:59:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 15:59:08]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Mikhail, 2016-12-13 16:10:54]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 16:11:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-12-13 16:17:41]

mikhail.pozdnyakov@intel.com changed reviewers:
+ jameswest@chromium.org

[Mikhail, 2016-12-13 16:37:35]

Please take a look

[commit-bot: I haz the power, 2016-12-13 17:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 17:42:36]

Dry run: This issue passed the CQ dry run.

[chcunningham, 2016-12-13 20:20:38]

LTGM % perf tests confirming things look good.

Can you run the Audio tests from this file with / without your change and let me
know the results?

https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest.h?l=44...

[chcunningham, 2016-12-13 20:21:06]

On 2016/12/13 20:20:38, chcunningham wrote:
> LTGM % perf tests confirming things look good.
> 
> Can you run the Audio tests from this file with / without your change and let
me
> know the results?
> 
>
https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest.h?l=44...

typo - LGTM % perf tests confirming things look good.

[James West, 2016-12-13 22:20:09]

lgtm

[Mikhail, 2016-12-14 08:50:30]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[commit-bot: I haz the power, 2016-12-14 08:50:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 08:55:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481705430908280,
"parent_rev": "e3a5116028a472cb5c78620878e2eddaad314c59", "commit_rev":
"7f63c7f52091f47f2399048a76db41053c85c98c"}

[commit-bot: I haz the power, 2016-12-14 08:56:04]

Description was changed from

==========
Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of
AudioTimestampHelper::TimeToFrames() more accurate.

Before, this translation was eating frames on each call, leading to significant
loss of accuracy in AudioConverter: initial delay of 0.011609s at
'AudioRendererMixer::Render' changed to 0.011587s
'AudioRendererMixerInput::ProvideInput'.

BUG=619533
==========

to

==========
Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of
AudioTimestampHelper::TimeToFrames() more accurate.

Before, this translation was eating frames on each call, leading to significant
loss of accuracy in AudioConverter: initial delay of 0.011609s at
'AudioRendererMixer::Render' changed to 0.011587s
'AudioRendererMixerInput::ProvideInput'.

BUG=619533

Review-Url: https://codereview.chromium.org/2562243005
==========

[commit-bot: I haz the power, 2016-12-14 08:56:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 08:57:44]

Description was changed from

==========
Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of
AudioTimestampHelper::TimeToFrames() more accurate.

Before, this translation was eating frames on each call, leading to significant
loss of accuracy in AudioConverter: initial delay of 0.011609s at
'AudioRendererMixer::Render' changed to 0.011587s
'AudioRendererMixerInput::ProvideInput'.

BUG=619533

Review-Url: https://codereview.chromium.org/2562243005
==========

to

==========
Make AudioTimestampHelper::TimeToFrames() more accurate

This patch uses 'std::round' to make result of
AudioTimestampHelper::TimeToFrames() more accurate.

Before, this translation was eating frames on each call, leading to significant
loss of accuracy in AudioConverter: initial delay of 0.011609s at
'AudioRendererMixer::Render' changed to 0.011587s
'AudioRendererMixerInput::ProvideInput'.

BUG=619533

Committed: https://crrev.com/900df16a521d74065ed5c566e563eb29d317ae91
Cr-Commit-Position: refs/heads/master@{#438464}
==========

[commit-bot: I haz the power, 2016-12-14 08:57:45]

Patchset 2 (id:??) landed as
https://crrev.com/900df16a521d74065ed5c566e563eb29d317ae91
Cr-Commit-Position: refs/heads/master@{#438464}