|
|
Chromium Code Reviews|
Created:
4 years ago by tommycli Modified:
4 years ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Fix CrOS /help/details edge case for MainPageBehavior.
Without this, an assertion is triggered, since inSearchMode is updated
before the element is attached.
BUG=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/5a513840d307f122738b474103e19c5e0615c8cc
Cr-Commit-Position: refs/heads/master@{#438204}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. Without this, an assertion is triggered, since inSearchMode is updated before the element is attached. BUG=NONE ========== to ========== MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. Without this, an assertion is triggered, since inSearchMode is updated before the element is attached. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
tommycli@chromium.org changed reviewers: + stevenjb@chromium.org
stevenjb: PTAL, thanks!
That seems to do the trick, lgtm.
The CQ bit was checked by tommycli@chromium.org
thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481647352121050, "parent_rev":
"70c40051a0d62c1c6cbe0b7f53caf6ecc1664d00", "commit_rev":
"0e55627d6089f57fd40521a7bb9683881e703249"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. Without this, an assertion is triggered, since inSearchMode is updated before the element is attached. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. Without this, an assertion is triggered, since inSearchMode is updated before the element is attached. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2562153002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. Without this, an assertion is triggered, since inSearchMode is updated before the element is attached. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2562153002 ========== to ========== MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. Without this, an assertion is triggered, since inSearchMode is updated before the element is attached. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5a513840d307f122738b474103e19c5e0615c8cc Cr-Commit-Position: refs/heads/master@{#438204} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5a513840d307f122738b474103e19c5e0615c8cc Cr-Commit-Position: refs/heads/master@{#438204} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
