Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2562153002: MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. Without this, an assertion is triggered, since inSearchMode is updated before the element is attached. BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5a513840d307f122738b474103e19c5e0615c8cc Cr-Commit-Position: refs/heads/master@{#438204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
tommycli
stevenjb: PTAL, thanks!
4 years ago (2016-12-09 22:46:22 UTC) #3
stevenjb
That seems to do the trick, lgtm.
4 years ago (2016-12-09 23:12:55 UTC) #4
tommycli
thanks!
4 years ago (2016-12-09 23:17:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562153002/1
4 years ago (2016-12-09 23:18:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on ...
4 years ago (2016-12-10 01:21:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562153002/1
4 years ago (2016-12-12 18:27:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/278187)
4 years ago (2016-12-13 01:50:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562153002/1
4 years ago (2016-12-13 16:43:21 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 17:28:01 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-13 17:30:55 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a513840d307f122738b474103e19c5e0615c8cc
Cr-Commit-Position: refs/heads/master@{#438204}

Powered by Google App Engine
This is Rietveld 408576698