Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6799)

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2562153002: MD Settings: Fix CrOS /help/details edge case for MainPageBehavior. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index ce1581225272332145660dd1e31012a22fad65e4..fd15c75f0ae7886d02fbac1ad530f248703ce354 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -66,6 +66,9 @@ var MainPageBehaviorImpl = {
* @private
*/
inSearchModeChanged_: function(inSearchMode) {
+ if (!this.isAttached)
+ return;
+
if (!inSearchMode)
this.tryTransitionToSection_(!settings.lastRouteChangeWasPopstate());
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698