Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 256213002: [Android] Reland "Provide unhandled tap event notifications" (Closed)

Created:
6 years, 7 months ago by jdduke (slow)
Modified:
6 years, 7 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Reland "Provide unhandled tap event notifications" Allow notifications of unhandled taps via the GestureStateListener. This change makes GestureTap events blocking, but there are several use-cases for which this will be necessary, e.g., WebView and contextual search. This was landed in r26143 and reverted in r261470 due to to a failure in TouchEditableImplAuraTest.TouchCursorInTextfieldTest. The test has been fixed and reviewed previously in crrev.com/218633008. BUG=355154 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266732

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +9 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/GestureStateListener.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-04-28 18:24:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/256213002/1
6 years, 7 months ago (2014-04-28 18:26:26 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 19:02:36 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_clang_dbg
6 years, 7 months ago (2014-04-28 19:02:37 UTC) #4
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-04-28 19:52:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/256213002/20001
6 years, 7 months ago (2014-04-28 19:53:02 UTC) #6
commit-bot: I haz the power
Change committed as 266732
6 years, 7 months ago (2014-04-29 01:52:19 UTC) #7
Michael Achenbach
6 years, 7 months ago (2014-04-29 10:32:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/259073005/ by machenbach@chromium.org.

The reason for reverting is: The test TouchCursorInTextfieldTest is failing
flakily on Linux ChromiumOS Tests (2):

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

The precondition CL crrev.com/218633008 also got previously reverted..

Powered by Google App Engine
This is Rietveld 408576698