content/browser/renderer_host/input/input_router_impl_unittest.cc - Issue 256213002: [Android] Reland "Provide unhandled tap event notifications"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_impl_unittest.cc

Issue 256213002: [Android] Reland "Provide unhandled tap event notifications" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/web_contents/touch_editable_impl_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/input_router_impl_unittest.cc

diff --git a/content/browser/renderer_host/input/input_router_impl_unittest.cc b/content/browser/renderer_host/input/input_router_impl_unittest.cc

index 69adf747ef95443f9dbe1a10cc7d1abc2fa4a8fa..de00b479265e0b283cdd2dbce79dffdccd3256d8 100644

--- a/content/browser/renderer_host/input/input_router_impl_unittest.cc

+++ b/content/browser/renderer_host/input/input_router_impl_unittest.cc

@@ -1279,10 +1279,17 @@ TEST_F(InputRouterImplTest, DoubleTapGestureDependsOnFirstTap) {

EXPECT_EQ(1U, GetSentMessageCountAndResetSink());

// The GestureTapUnconfirmed is converted into a tap, as the touch action is

- // auto.

+ // none.

SimulateGestureEvent(WebInputEvent::GestureTapUnconfirmed,

WebGestureEvent::Touchscreen);

EXPECT_EQ(1U, GetSentMessageCountAndResetSink());

+ // This test will become invalid if GestureTap stops requiring an ack.

+ ASSERT_FALSE(WebInputEventTraits::IgnoresAckDisposition(

+ GetEventWithType(WebInputEvent::GestureTap)));

+ EXPECT_EQ(2, client_->in_flight_event_count());

+ SendInputEventACK(WebInputEvent::GestureTap,

+ INPUT_EVENT_ACK_STATE_CONSUMED);

+ EXPECT_EQ(1, client_->in_flight_event_count());

// This tap gesture is dropped, since the GestureTapUnconfirmed was turned

// into a tap.

@@ -1304,8 +1311,10 @@ TEST_F(InputRouterImplTest, DoubleTapGestureDependsOnFirstTap) {

SimulateGestureEvent(WebInputEvent::GestureDoubleTap,

WebGestureEvent::Touchscreen);

// This test will become invalid if GestureDoubleTap stops requiring an ack.

- DCHECK(!WebInputEventTraits::IgnoresAckDisposition(

- GetEventWithType(WebInputEvent::GestureDoubleTap)));

+ ASSERT_FALSE(WebInputEventTraits::IgnoresAckDisposition(

+ GetEventWithType(WebInputEvent::GestureDoubleTap)));

+ EXPECT_EQ(1, client_->in_flight_event_count());

+ SendInputEventACK(WebInputEvent::GestureTap, INPUT_EVENT_ACK_STATE_CONSUMED);

EXPECT_EQ(0, client_->in_flight_event_count());

}