content/browser/web_contents/touch_editable_impl_aura_browsertest.cc - Issue 256213002: [Android] Reland "Provide unhandled tap event notifications"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

Issue 256213002: [Android] Reland "Provide unhandled tap event notifications" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/input_router_impl_unittest.cc ('k') | content/common/input/web_input_event_traits.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

diff --git a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

index f9c84a6e398385dfb5c5f2684d49cfe481a53f12..9cbbf8139690ea5916ce8bc31a4dd274328e56eb 100644

--- a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

+++ b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

@@ -369,9 +369,10 @@ IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,

// Tap textfield

touch_editable->Reset();

generator.GestureTapAt(gfx::Point(bounds.x() + 50, bounds.y() + 40));

- // Tap Down and Tap acks are sent synchronously.

- touch_editable->WaitForSelectionChangeCallback();

+ // Tap Down acks are sent synchronously, while Tap acks are asynchronous.

touch_editable->Reset();

+ touch_editable->WaitForGestureAck();

+ touch_editable->WaitForSelectionChangeCallback();

// Check if cursor handle is showing.

EXPECT_NE(ui::TEXT_INPUT_TYPE_NONE, GetTextInputType(touch_editable));