Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2562023002:
Fixed typo in quick view for a text to have proper margin. (Closed)
|
Created:
4 years ago by oka Modified:
4 years ago Reviewers:
fukino CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixed typo in quick view for a text to have proper margin.
Fixed typo in quick view for no playback available message to have proper margin between the icon.
BUG=None
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/5974e6f7809edd3cb6e56bc6b5673bfe4296794c
Cr-Commit-Position: refs/heads/master@{#438773}
Patch Set 1 #Patch Set 2 : Fixed one more typo. #Patch Set 3 : Rebased. #
Depends on Patchset: Messages
Total messages: 24 (17 generated)
Description was changed from ========== Fixed typo. BUG=None TEST=manually. ========== to ========== Fixed typo. BUG=None TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Fixed typo. BUG=None TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fixed typo in quick view for a text to have proper margin. Fixed typo in quick view for no playback available message to have proper margin between the icon. BUG=None TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
oka@chromium.org changed reviewers: + fukino@chromium.org
PTAL.
The CQ bit was checked by oka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by oka@chromium.org
The CQ bit was unchecked by oka@chromium.org
The CQ bit was checked by oka@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2561633006 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by oka@chromium.org to run a CQ dry run
The CQ bit was checked by oka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org Link to the patchset: https://codereview.chromium.org/2562023002/#ps40001 (title: "Rebased.")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2561633006 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by oka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481784804321440,
"parent_rev": "e693441709991ab3ea222d4f9af88b644698e938", "commit_rev":
"0060bf7e5683085ea78928f31e69ea6fb53d1154"}
Message was sent while issue was closed.
Description was changed from ========== Fixed typo in quick view for a text to have proper margin. Fixed typo in quick view for no playback available message to have proper margin between the icon. BUG=None TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fixed typo in quick view for a text to have proper margin. Fixed typo in quick view for no playback available message to have proper margin between the icon. BUG=None TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2562023002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fixed typo in quick view for a text to have proper margin. Fixed typo in quick view for no playback available message to have proper margin between the icon. BUG=None TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2562023002 ========== to ========== Fixed typo in quick view for a text to have proper margin. Fixed typo in quick view for no playback available message to have proper margin between the icon. BUG=None TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5974e6f7809edd3cb6e56bc6b5673bfe4296794c Cr-Commit-Position: refs/heads/master@{#438773} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5974e6f7809edd3cb6e56bc6b5673bfe4296794c Cr-Commit-Position: refs/heads/master@{#438773} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
