Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2561633006: Quick View: Show folder icon if folder is selected. (Closed)

Created:
4 years ago by oka
Modified:
4 years ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick View: Show folder icon if folder is selected. If user opens a Quick View for a folder, show the folder icon instead of the generic file icon with no preview available message. BUG=None TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/5e0dca78b33b8ca55b232452093970160a6c4b3a Cr-Commit-Position: refs/heads/master@{#438769}

Patch Set 1 #

Patch Set 2 : Refactor: removed repeated center, no-repeat. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_quick_view.css View 1 1 chunk +13 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.html View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
oka
PTAL.
4 years ago (2016-12-09 11:04:44 UTC) #4
fukino
lgtm
4 years ago (2016-12-09 11:10:59 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2540863004 Patch 100001). Please resolve the dependency and ...
4 years ago (2016-12-09 11:18:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561633006/20001
4 years ago (2016-12-15 06:21:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 06:46:10 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 06:48:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e0dca78b33b8ca55b232452093970160a6c4b3a
Cr-Commit-Position: refs/heads/master@{#438769}

Powered by Google App Engine
This is Rietveld 408576698