Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2562003002: [wasm] Remove obsolete %IsNotAsmWasmCode predicate. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove obsolete %IsNotAsmWasmCode predicate. By now the predicate in question is an exact negation of %IsAsmWasmCode as the name intuitively implies. The need for two separate test methods no longer exists and one of the two can be removed. R=bradnelson@chromium.org Committed: https://crrev.com/75128636f31636ab4695b9c75d986bcca654a1f5 Cr-Commit-Position: refs/heads/master@{#41616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -58 lines) Patch
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +7 lines, -21 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 12 chunks +15 lines, -15 lines 0 comments Download
M test/mjsunit/asm/regress-672045.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-575364.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-599825.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-613928.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-617525.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-617529.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-618608.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-wasm-crbug-599413.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-wasm-crbug-618602.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 7 chunks +7 lines, -7 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm-stdlib.js View 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Michael Starzinger
4 years ago (2016-12-09 11:29:23 UTC) #4
bradnelson
lgtm
4 years ago (2016-12-09 11:53:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562003002/1
4 years ago (2016-12-09 11:54:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 11:55:46 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-09 11:56:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75128636f31636ab4695b9c75d986bcca654a1f5
Cr-Commit-Position: refs/heads/master@{#41616}

Powered by Google App Engine
This is Rietveld 408576698