Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 2549463002: [wasm] Cleanup %IsAsmWasmCode testing predicate. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
bradnelson, rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Cleanup %IsAsmWasmCode testing predicate. By now the compiler pipeline will not produce optimized code for asm.js functions unless validation failed (even when --always-opt is enabled). The related workaround in the testing predicate can be removed. R=rmcilroy@chromium.org Committed: https://crrev.com/9fde10ebed493bc9fc9030f146061f1fda0d5a9c Cr-Commit-Position: refs/heads/master@{#41614}

Patch Set 1 #

Patch Set 2 : Fix failures. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/runtime/runtime-test.cc View 1 2 2 chunks +8 lines, -9 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
Michael Starzinger
4 years ago (2016-12-09 10:52:20 UTC) #9
bradnelson
lgtm
4 years ago (2016-12-09 11:01:16 UTC) #10
rmcilroy
lgtm
4 years ago (2016-12-09 11:24:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549463002/40001
4 years ago (2016-12-09 11:28:19 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-09 11:30:01 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-09 11:30:15 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9fde10ebed493bc9fc9030f146061f1fda0d5a9c
Cr-Commit-Position: refs/heads/master@{#41614}

Powered by Google App Engine
This is Rietveld 408576698