components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc - Issue 2561983002: NavigationController: Reload methods migration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

Issue 2561983002: NavigationController: Reload methods migration (Closed)

Patch Set: one more mac build fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc ('K') | « chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc ('k') | content/browser/child_process_security_policy_browsertest.cc » ('j') | content/browser/devtools/protocol/page_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

index e7b47a523771fc1aa624353330e4402bf89600ce..49d375eaa554c802e9584a459bb3a2a4b77213be 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc

@@ -137,7 +137,7 @@ void ContentSubresourceFilterDriverFactory::OnReloadRequested() {

UMA_HISTOGRAM_BOOLEAN("SubresourceFilter.Prompt.NumReloads", true);

const GURL whitelist_url(web_contents()->GetLastCommittedURL());

AddHostOfURLToWhitelistSet(whitelist_url);

- web_contents()->GetController().Reload(true);

+ web_contents()->GetController().Reload(content::ReloadType::NORMAL, true);

}

void ContentSubresourceFilterDriverFactory::SetDriverForFrameHostForTesting(