Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/devtools/protocol/page_handler.cc

Issue 2561983002: NavigationController: Reload methods migration (Closed)
Patch Set: one more mac build fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc ('K') | « content/browser/child_process_security_policy_browsertest.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | content/browser/frame_host/navigation_controller_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/page_handler.cc
diff --git a/content/browser/devtools/protocol/page_handler.cc b/content/browser/devtools/protocol/page_handler.cc
index f1361e7630c8641fe71f6be837a92b0aaf60554d..99e6ad202a1efb4789b6456a895c77c7e91c8cf4 100644
--- a/content/browser/devtools/protocol/page_handler.cc
+++ b/content/browser/devtools/protocol/page_handler.cc
@@ -214,10 +214,10 @@ Response PageHandler::Reload(Maybe<bool> bypassCache,
if (web_contents->IsCrashed() ||
(web_contents->GetController().GetVisibleEntry() &&
web_contents->GetController().GetVisibleEntry()->IsViewSourceMode())) {
- if (bypassCache.fromMaybe(false))
- web_contents->GetController().ReloadBypassingCache(false);
- else
- web_contents->GetController().Reload(false);
+ web_contents->GetController().Reload(bypassCache.fromMaybe(false)
+ ? ReloadType::BYPASSING_CACHE
+ : ReloadType::NORMAL,
+ false);
Takashi Toyoshima 2016/12/15 06:21:52 devtools will be ok to use false
return Response::OK();
} else {
// Handle reload in renderer except for crashed and view source mode.
« chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc ('K') | « content/browser/child_process_security_policy_browsertest.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.cc » ('j') | content/browser/frame_host/navigation_controller_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698