chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc - Issue 2561983002: NavigationController: Reload methods migration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc

Issue 2561983002: NavigationController: Reload methods migration (Closed)

Patch Set: one more mac build fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_instant_controller.cc ('K') | « chrome/browser/ui/collected_cookies_infobar_delegate.cc ('k') | chrome/browser/ui/sad_tab.cc » ('j') | content/browser/devtools/protocol/page_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc

diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc b/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc

index f0a31a4f8a39524e1c8f0452c049d426976f200a..d9be2a2551eca75ed3f15a825b6f79110527aa39 100644

--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc

+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc

@@ -35,7 +35,7 @@ IN_PROC_BROWSER_TEST_F(JavaScriptDialogTest, ReloadDoesntHang) {

// Try reloading.

- tab->GetController().Reload(false);

+ tab->GetController().Reload(content::ReloadType::NORMAL, false);

Takashi Toyoshima 2016/12/15 06:21:52 testing

content::WaitForLoadStop(tab);

// If the WaitForLoadStop doesn't hang forever, we've passed.