Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: third_party/crashpad/crashpad/util/posix/close_stdio.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/posix/close_stdio.cc
diff --git a/third_party/crashpad/crashpad/util/posix/close_stdio.cc b/third_party/crashpad/crashpad/util/posix/close_stdio.cc
index d58929474f75037270f653fb6e46711e67c3f9f3..422df5bb3b9704cde6ebfa3cc8966bffa3c56868 100644
--- a/third_party/crashpad/crashpad/util/posix/close_stdio.cc
+++ b/third_party/crashpad/crashpad/util/posix/close_stdio.cc
@@ -32,8 +32,10 @@ void CloseStdioStream(int desired_fd, int oflag) {
// Weird, but play along.
ignore_result(fd.release());
} else {
- PCHECK(fd.get() >= 0) << "open";
- PCHECK(HANDLE_EINTR(dup2(fd.get(), desired_fd)) != -1) << "dup2";
+ // open
+ CHECK(fd.get() >= 0);
+ // dup2
+ CHECK(HANDLE_EINTR(dup2(fd.get(), desired_fd)) != -1);
fd.reset();
}
}

Powered by Google App Engine
This is Rietveld 408576698