third_party/crashpad/crashpad/util/mach/composite_mach_message_server.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/util/mach/composite_mach_message_server.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/curtain_mode_mac.cc ('K') | « third_party/crashpad/crashpad/util/mach/child_port_handshake.cc ('k') | third_party/crashpad/crashpad/util/posix/close_stdio.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/util/mach/composite_mach_message_server.cc

diff --git a/third_party/crashpad/crashpad/util/mach/composite_mach_message_server.cc b/third_party/crashpad/crashpad/util/mach/composite_mach_message_server.cc

index abbe5bcf38858cc27934520b0140782701f902f6..ad6fb4adbc99d0074187c05759a7419dfe2a97c9 100644

--- a/third_party/crashpad/crashpad/util/mach/composite_mach_message_server.cc

+++ b/third_party/crashpad/crashpad/util/mach/composite_mach_message_server.cc

@@ -41,7 +41,8 @@ void CompositeMachMessageServer::AddHandler(

for (mach_msg_id_t request_id : request_ids) {

std::pair<HandlerMap::const_iterator, bool> result =

handler_map_.insert(std::make_pair(request_id, handler));

- CHECK(result.second) << "duplicate request ID " << request_id;

+ // duplicate request ID |request_id|

+ CHECK(result.second);

}

request_size_ =