third_party/cacheinvalidation/src/google/cacheinvalidation/impl/throttle.cc - Issue 2561963002: base: Remove the string logging from CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/cacheinvalidation/src/google/cacheinvalidation/impl/throttle.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)

Patch Set: checkstring: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/host/curtain_mode_mac.cc ('K') | « third_party/cacheinvalidation/src/google/cacheinvalidation/impl/run-state.h ('k') | third_party/cacheinvalidation/src/google/cacheinvalidation/test/deterministic-scheduler.cc » ('j') | ui/base/template_expressions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/cacheinvalidation/src/google/cacheinvalidation/impl/throttle.cc

diff --git a/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/throttle.cc b/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/throttle.cc

index fa84fc870cda307dd08472592740303c7d61e1ea..5ba107e6c8f5af90a53c412aa2ad637f738aebe8 100644

--- a/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/throttle.cc

+++ b/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/throttle.cc

@@ -36,8 +36,8 @@ Throttle::Throttle(

max_recent_events_ = 1;

for (size_t i = 0; i < static_cast<size_t>(rate_limits_.size()); ++i) {

const RateLimitP& rate_limit = rate_limits.Get(i);

- CHECK(rate_limit.window_ms() > rate_limit.count()) <<

- "Windows size too small";

+ // Windows size too small

+ CHECK(rate_limit.window_ms() > rate_limit.count());

max_recent_events_ = max(static_cast<int>(max_recent_events_),

rate_limits_.Get(i).count());

}