Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/cacheinvalidation/src/google/cacheinvalidation/impl/run-state.h

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/cacheinvalidation/src/google/cacheinvalidation/impl/run-state.h
diff --git a/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/run-state.h b/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/run-state.h
index f330438a637203d7bffddcf383daa9ac74e3c960..12a830bc46ff685234970e77467de283a0c3033f 100644
--- a/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/run-state.h
+++ b/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/run-state.h
@@ -41,8 +41,8 @@ class RunState {
*/
void Start() {
MutexLock m(&lock_);
- CHECK(current_state_ == RunStateP_State_NOT_STARTED) << "Cannot start: "
- << current_state_;
+ // Cannot start.
+ CHECK(current_state_ == RunStateP_State_NOT_STARTED);
current_state_ = RunStateP_State_STARTED;
}
@@ -52,8 +52,8 @@ class RunState {
*/
void Stop() {
MutexLock m(&lock_);
- CHECK(current_state_ == RunStateP_State_STARTED) << "Cannot stop: "
- << current_state_;
+ // Cannot stop.
+ CHECK(current_state_ == RunStateP_State_STARTED);
current_state_ = RunStateP_State_STOPPED;
}

Powered by Google App Engine
This is Rietveld 408576698