Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/cacheinvalidation/src/google/cacheinvalidation/impl/checking-invalidation-listener.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/cacheinvalidation/src/google/cacheinvalidation/impl/checking-invalidation-listener.cc
diff --git a/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/checking-invalidation-listener.cc b/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/checking-invalidation-listener.cc
index af5a4e5ed5d944f31822d77d3bb1f841fcbc8459..d9198405fc3600492544e67862c93fa3fcfd7366 100644
--- a/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/checking-invalidation-listener.cc
+++ b/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/checking-invalidation-listener.cc
@@ -39,7 +39,8 @@ CheckingInvalidationListener::CheckingInvalidationListener(
void CheckingInvalidationListener::Invalidate(
InvalidationClient* client, const Invalidation& invalidation,
const AckHandle& ack_handle) {
- CHECK(internal_scheduler_->IsRunningOnThread()) << "Not on internal thread";
+ // Not on internal thread
+ CHECK(internal_scheduler_->IsRunningOnThread());
statistics_->RecordListenerEvent(Statistics::ListenerEventType_INVALIDATE);
listener_scheduler_->Schedule(
Scheduler::NoDelay(),
@@ -51,7 +52,8 @@ void CheckingInvalidationListener::Invalidate(
void CheckingInvalidationListener::InvalidateUnknownVersion(
InvalidationClient* client, const ObjectId& object_id,
const AckHandle& ack_handle) {
- CHECK(internal_scheduler_->IsRunningOnThread()) << "Not on internal thread";
+ // Not on internal thread
+ CHECK(internal_scheduler_->IsRunningOnThread());
statistics_->RecordListenerEvent(
Statistics::ListenerEventType_INVALIDATE_UNKNOWN);
listener_scheduler_->Schedule(
@@ -63,7 +65,8 @@ void CheckingInvalidationListener::InvalidateUnknownVersion(
void CheckingInvalidationListener::InvalidateAll(
InvalidationClient* client, const AckHandle& ack_handle) {
- CHECK(internal_scheduler_->IsRunningOnThread()) << "Not on internal thread";
+ // Not on internal thread
+ CHECK(internal_scheduler_->IsRunningOnThread());
statistics_->RecordListenerEvent(
Statistics::ListenerEventType_INVALIDATE_ALL);
listener_scheduler_->Schedule(
@@ -76,7 +79,8 @@ void CheckingInvalidationListener::InvalidateAll(
void CheckingInvalidationListener::InformRegistrationFailure(
InvalidationClient* client, const ObjectId& object_id,
bool is_transient, const string& error_message) {
- CHECK(internal_scheduler_->IsRunningOnThread()) << "Not on internal thread";
+ // Not on internal thread
+ CHECK(internal_scheduler_->IsRunningOnThread());
statistics_->RecordListenerEvent(
Statistics::ListenerEventType_INFORM_REGISTRATION_FAILURE);
listener_scheduler_->Schedule(
@@ -89,7 +93,8 @@ void CheckingInvalidationListener::InformRegistrationFailure(
void CheckingInvalidationListener::InformRegistrationStatus(
InvalidationClient* client, const ObjectId& object_id,
RegistrationState reg_state) {
- CHECK(internal_scheduler_->IsRunningOnThread()) << "Not on internal thread";
+ // Not on internal thread
+ CHECK(internal_scheduler_->IsRunningOnThread());
statistics_->RecordListenerEvent(
Statistics::ListenerEventType_INFORM_REGISTRATION_STATUS);
listener_scheduler_->Schedule(
@@ -101,7 +106,8 @@ void CheckingInvalidationListener::InformRegistrationStatus(
void CheckingInvalidationListener::ReissueRegistrations(
InvalidationClient* client, const string& prefix, int prefix_len) {
- CHECK(internal_scheduler_->IsRunningOnThread()) << "Not on internal thread";
+ // Not on internal thread
+ CHECK(internal_scheduler_->IsRunningOnThread());
statistics_->RecordListenerEvent(
Statistics::ListenerEventType_REISSUE_REGISTRATIONS);
listener_scheduler_->Schedule(
@@ -113,7 +119,8 @@ void CheckingInvalidationListener::ReissueRegistrations(
void CheckingInvalidationListener::InformError(
InvalidationClient* client, const ErrorInfo& error_info) {
- CHECK(internal_scheduler_->IsRunningOnThread()) << "Not on internal thread";
+ // Not on internal thread
+ CHECK(internal_scheduler_->IsRunningOnThread());
statistics_->RecordListenerEvent(
Statistics::ListenerEventType_INFORM_ERROR);
listener_scheduler_->Schedule(
@@ -123,7 +130,8 @@ void CheckingInvalidationListener::InformError(
}
void CheckingInvalidationListener::Ready(InvalidationClient* client) {
- CHECK(internal_scheduler_->IsRunningOnThread()) << "Not on internal thread";
+ // Not on internal thread
+ CHECK(internal_scheduler_->IsRunningOnThread());
TLOG(logger_, INFO, "Informing app that ticl is ready");
listener_scheduler_->Schedule(
Scheduler::NoDelay(),

Powered by Google App Engine
This is Rietveld 408576698