Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: third_party/cacheinvalidation/src/google/cacheinvalidation/impl/basic-system-resources.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/cacheinvalidation/src/google/cacheinvalidation/impl/basic-system-resources.cc
diff --git a/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/basic-system-resources.cc b/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/basic-system-resources.cc
index 0b2c24f25596dc5d167c24fd598ffd7aa4349399..8b07dd220064eb36ef00d322069b982cc3628054 100644
--- a/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/basic-system-resources.cc
+++ b/third_party/cacheinvalidation/src/google/cacheinvalidation/impl/basic-system-resources.cc
@@ -37,7 +37,8 @@ BasicSystemResources::~BasicSystemResources() {
}
void BasicSystemResources::Start() {
- CHECK(!run_state_.IsStarted()) << "resources already started";
+ // resources already started
+ CHECK(!run_state_.IsStarted());
// TODO(ghc): Investigate whether we should have Start() and Stop() methods
// on components like the scheduler. Otherwise, the resources can't start and
@@ -46,8 +47,10 @@ void BasicSystemResources::Start() {
}
void BasicSystemResources::Stop() {
- CHECK(run_state_.IsStarted()) << "cannot stop resources that aren't started";
- CHECK(!run_state_.IsStopped()) << "resources already stopped";
+ // cannot stop resources that aren't started
+ CHECK(run_state_.IsStarted());
+ // resources already stopped
+ CHECK(!run_state_.IsStopped());
run_state_.Stop();
}

Powered by Google App Engine
This is Rietveld 408576698