Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: storage/browser/blob/blob_storage_context.cc

Issue 2561963002: base: Remove the string logging from CHECK(). (Closed)
Patch Set: checkstring: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/blob_storage_context.cc
diff --git a/storage/browser/blob/blob_storage_context.cc b/storage/browser/blob/blob_storage_context.cc
index acc086e57c04070c32968b932f0dbec5ebc218e8..54a49ed51f71319d7f02cffe24f4c5e46f4834e3 100644
--- a/storage/browser/blob/blob_storage_context.cc
+++ b/storage/browser/blob/blob_storage_context.cc
@@ -367,7 +367,8 @@ BlobStorageContext::BlobSlice::BlobSlice(const BlobEntry& source,
}
case DataElement::TYPE_BLOB:
case DataElement::TYPE_UNKNOWN:
- CHECK(false) << "Illegal blob item type: " << type;
+ // Illegal blob item type.
+ CHECK(false);
}
dest_items.push_back(
new ShareableBlobDataItem(std::move(data_item), state));
@@ -575,7 +576,8 @@ void BlobStorageContext::CancelBuildingBlob(const std::string& uuid,
void BlobStorageContext::NotifyTransportComplete(const std::string& uuid) {
BlobEntry* entry = registry_.GetEntry(uuid);
- CHECK(entry) << "There is no blob entry with uuid " << uuid;
+ // There is no blob entry with uuid |uuid|
+ CHECK(entry);
DCHECK(BlobStatusIsPending(entry->status()));
NotifyTransportCompleteInternal(entry);
}

Powered by Google App Engine
This is Rietveld 408576698